feat(ui): add navigation trails to GitHub and work-item details - #696
Merged
Conversation
Harry19081
marked this pull request as ready for review
August 6, 2026 03:44
…navigation-trail # Conflicts: # src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrDetailPanel.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub Issue, Work Item, Team Inbox assigned-item, and Pull Request details do not provide the persistent timeline navigation available in Sessions. Long descriptions and activity streams require manual scrolling, and earlier overlay-style navigation could disappear because of overflow, breakpoint, or marker-count gates.
Solution
Add a shared ScrollTrail that discovers semantic destinations, samples dense timelines to at most 20 markers, tracks the active destination, and supports click, hover, focus, and reduced-motion navigation. Work Item and Pull Request details now reserve a permanent 44px backgroundless and borderless right rail. GitHub Issues inherit the Work Item rail; Team Inbox assigned items and Pull Requests reuse the same owning detail surfaces. Sparse surfaces retain a root marker so the rail remains visible without overflow or multiple destinations.
The scroll listener is passive and frame-coalesced. Mutation and resize observation is scoped to the mounted detail content and fully disposed on unmount. No API, persistence, wire-format, dependency, or lockfile changes are included.
Potential risks
developbehavior.Verification
Passed before publication:
pnpm exec vitest run src/modules/shared/layouts/blocks/ScrollTrail.test.ts src/modules/shared/components/ActivityTimeline/ActivityTimeline.test.ts src/modules/ProjectManager/WorkItems/components/GitHubIssueThreadSurface.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemContent/__tests__/HistoryTab.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemContent/__tests__/WorkItemDescriptionEditing.test.ts src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrDetailPanel.test.ts src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrConversationTab.test.ts— 50 tests across 7 files.pnpm exec eslinton all changed TypeScript and TSX files.pnpm exec prettier --checkon all changed source and acceptance-test files.pnpm typecheck.pnpm check:circular— no circular dependencies across 6,188 modules.git diff --check origin/develop...HEAD.Passed after merging current
developand resolving the shared PR-panel conflict:npx vitest run src/modules/shared/layouts/blocks/ScrollTrail.test.ts src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrDetailPanel.test.ts src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrConversationTab.test.ts src/modules/ProjectManager/WorkItems/components/GitHubIssueThreadSurface.test.ts src/modules/ProjectManager/WorkItems/components/WorkItemContent/__tests__/WorkItemDescriptionEditing.test.ts src/modules/shared/components/ActivityTimeline/ActivityTimeline.test.ts— 44 tests across 6 files.npx tsc --noEmit --pretty false.npx eslint src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrDetailPanel.tsx src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrDetailPanel.test.ts src/modules/WorkStation/CodeEditor/Panels/EditorPrimarySidebar/content/PullRequestContent/detail/PrConversationTab.tsx.integrationsandorgtrack_core.Not run:
Audit
The configured frontend-ui-audit skill was unavailable in this workspace. Manual review confirmed the rail reuses existing Session marker sizing, colors, focus treatment, sampling limit, reduced-motion behavior, and observer cleanup discipline.